Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-core): add UiProgressBar component #8410

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OlivierFL
Copy link
Collaborator

@OlivierFL OlivierFL commented Mar 5, 2025

Description

Add UiProgressBar component.

The steps’ display behavior is as follows:

  • when the prop showSteps is set to true, the values 0% and 100% are displayed for percentages under 100
  • when the prop showSteps is set to true or percentage exceeds 100, the steps are always shown and updated according to the current percentage (see examples in the screenshot below)

Screenshots

ui-progress-bar

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@OlivierFL OlivierFL self-assigned this Mar 5, 2025
@OlivierFL OlivierFL force-pushed the xo6/add-ui-progress-bar branch 2 times, most recently from 67f0d5f to 39c142e Compare March 5, 2025 11:19
@OlivierFL OlivierFL marked this pull request as ready for review March 5, 2025 11:20
@OlivierFL OlivierFL requested a review from S3bastianCZ March 5, 2025 11:20
@OlivierFL OlivierFL force-pushed the xo6/add-ui-progress-bar branch 2 times, most recently from 5920e8b to fb27925 Compare March 5, 2025 14:06
@OlivierFL OlivierFL removed the request for review from S3bastianCZ March 6, 2025 09:12
@OlivierFL OlivierFL marked this pull request as draft March 6, 2025 09:12
@OlivierFL OlivierFL force-pushed the xo6/add-ui-progress-bar branch from fb27925 to 2803a12 Compare March 6, 2025 09:14
@OlivierFL OlivierFL force-pushed the xo6/add-ui-progress-bar branch from 5e94cab to d558c92 Compare March 10, 2025 08:57
@OlivierFL OlivierFL marked this pull request as ready for review March 10, 2025 08:57
@OlivierFL OlivierFL requested a review from S3bastianCZ March 10, 2025 09:09
Copy link
Contributor

@S3bastianCZ S3bastianCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@S3bastianCZ S3bastianCZ requested a review from ByScripts March 10, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants