Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backups): handle case when a new disk is added to a replicated VM #8400

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Mar 4, 2025

Description

first replication fails after adding a disk to a VM
this PR will fallback to full disk transfer if an existing replica is not found

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@fbeauchamp fbeauchamp requested a review from b-Nollet March 6, 2025 16:12
@b-Nollet b-Nollet requested a review from MathieuRA March 7, 2025 10:24
@fbeauchamp fbeauchamp force-pushed the fix_partial_replication branch from ac31b39 to d9b23c9 Compare March 7, 2025 13:55
@fbeauchamp fbeauchamp requested a review from b-Nollet March 7, 2025 13:57
@fbeauchamp fbeauchamp requested a review from MathieuRA March 7, 2025 14:35
@fbeauchamp fbeauchamp removed the request for review from b-Nollet March 7, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants