Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@xen-orchestra/rest-api): expose VM stats #8359

Merged
merged 15 commits into from
Mar 6, 2025
Merged

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Feb 19, 2025

Screenshot

Capture d’écran de 2025-02-19 11-03-30

Description

wait for #8356

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@MathieuRA MathieuRA self-assigned this Feb 19, 2025
@MathieuRA MathieuRA removed the request for review from MelissaFrncJrg February 21, 2025 08:58
Base automatically changed from swagger-vms to master February 21, 2025 09:32
@MathieuRA MathieuRA marked this pull request as ready for review February 21, 2025 13:35
@MathieuRA MathieuRA requested a review from b-Nollet February 21, 2025 13:50
Copy link
Contributor

@b-Nollet b-Nollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add @xen-orchestra/rest-api to the packages to release when rebasing on master

@MathieuRA MathieuRA requested review from b-Nollet and removed request for b-Nollet February 28, 2025 16:33
@MathieuRA MathieuRA requested a review from b-Nollet February 28, 2025 16:40
@fbeauchamp
Copy link
Collaborator

you can resolve the conflicts and merge

@MathieuRA MathieuRA merged commit 034d9b5 into master Mar 6, 2025
1 check passed
@MathieuRA MathieuRA deleted the expose-vms-stats branch March 6, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants