Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server/xo-web): show format used in the disk lists #8341

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stephane-m-dev
Copy link
Contributor

@stephane-m-dev stephane-m-dev commented Feb 12, 2025

Description

XO-547

Show format used in the disks lists (SR/VM).
Makes use of "supported_image_formats" which will be implemented on the xcp side at the end of March.

Capture d’écran du 2025-02-12 10-14-00
Capture d’écran du 2025-02-12 10-13-09

listevdis

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@stephane-m-dev stephane-m-dev force-pushed the sr-vm-show-disk-type-format branch 2 times, most recently from cbb6db0 to f2ada53 Compare February 12, 2025 09:17
@stephane-m-dev stephane-m-dev force-pushed the sr-vm-show-disk-type-format branch from 39ac010 to 629877f Compare February 19, 2025 09:10
@b-Nollet b-Nollet requested a review from pdonias February 19, 2025 14:55
@pdonias pdonias removed their request for review March 10, 2025 08:54
@pdonias pdonias self-assigned this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants