Fix ISO alpha and numeric code definitions in Currency objects #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharra
force-pushed
the
fix_currency_iso_definitions
branch
from
b2ce34e to
4bd0e01
Compare
|
Thank you, really appreciate the fix and PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
while using this library I noticed that the
Currency::find()function is returning an error for the HUF currency (InvalidCurrency). Investigating further, I found that the issue lies in the definitions of the ISO alpha codes in theCurrencyobjects in the iso.rs file.Due to the way the lookup maps are populated in currency.rs (using the
iso_alpha_codefield as key) this also causes the function to return the wrongCurrencyobject for HTG, since the values in the hash map get overridden due to the duplicate values.The PR also contains a fix for a similar copy-paste bug regarding the numeric codes as well as some tests to ensure those kind of bugs are caught before being merged. I put them in the same file, if you don't mind.