Implement multiple/division with decimals #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it's useful to multiply amounts by non-integer values; Given Money already uses decimal internally allow it to be multiplied/divided by decimals as well which should suitable for this. Signed-off-by: Sjoerd Simons <[email protected]>
All the multiple/division calcucation first convert the non-money type to string which is then converted to a Decimal. That's a bit pointless as Decimal implements the From trait for all relevant types already. Signed-off-by: Sjoerd Simons <[email protected]>
|
Thank you for putting this together, I'm supportive of adding this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's useful to multiply amounts by non-integer values; Given
Money already uses decimal internally allow it to be multiplied/divided by
decimals as well which should suitable for this.
Signed-off-by: Sjoerd Simons [email protected]