Don’t set delayUntil if there is no delay
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
- Coverage 84.83% 84.57% -0.27%
==========================================
Files 22 22
Lines 765 765
==========================================
- Hits 649 647 -2
- Misses 116 118 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 1.17.1
Currently, if a job is retried with no delay, the
delayUntilproperty is set to the current time. I noticed this since it was causing some issues with a new test in vapor-community/vapor-queues-fluent-driver#15. This PR adjusts this so thatdelayUntilisnilwhen there is no retry delay. This aligns the behaviour with how new jobs with no delay are created.