Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling #68

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Improve error handling #68

merged 1 commit into from
Dec 6, 2021

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Dec 1, 2021

  • "Connection closed" errors are now correctly reported when trying to issue queries on closed connections, instead of throwing various NIO errors.
  • Query syntax errors are now explicitly reported.
  • Unique constraint violation errors are now more consistently reported.

semver-minor due to adding a new case on MySQLError.

@gwynne gwynne added enhancement New feature or request semver-minor Contains new API labels Dec 1, 2021
@gwynne gwynne self-assigned this Dec 1, 2021
@gwynne gwynne merged commit f0e8ad7 into main Dec 6, 2021
@gwynne gwynne deleted the improved-error-handling branch December 6, 2021 19:42
@VaporBot
Copy link

VaporBot commented Dec 6, 2021

These changes are now available in 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@jdmcd jdmcd Awaiting requested review from jdmcd

@calebkleveter calebkleveter Awaiting requested review from calebkleveter

Assignees

@gwynne gwynne

Labels
enhancement New feature or request semver-minor Contains new API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwynne @VaporBot @0xTim