Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix statement close during binding #34

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Fix statement close during binding #34

merged 3 commits into from
Jun 29, 2020

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Jun 29, 2020 •
edited
Loading

Fixes an issue causing prepared statements to not close if an error happened during parameter binding (#34).

notes: MySQL NIO will now assert that statements have been closed before the query handler deinitializes.

@tanner0101 tanner0101 added bug Something isn't working semver-patch Internal changes only labels Jun 29, 2020
@tanner0101 tanner0101 merged commit 6ac341a into master Jun 29, 2020
@tanner0101
Copy link
Member Author

These changes are now available in 1.0.0-rc.2.4

@tanner0101 tanner0101 deleted the tn-statement-close branch June 29, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tanner0101