General cleanup #237
Merged
General cleanup #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be async and use modern Vapor testing utilities. Tests no longer fail if SWIFT_DETERMINISTIC_HASHING isn't set. Moved the test templates under the tests directory.
…n comments in LeafEncoder implementation. Use `some Encodable` etc. where possible. Silence retroactive conformance warnings.
…Leaf template because it might not be valid as one.
0xTim
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.5.0
Herein we bump the minimum Swift version to 5.10, fix a lingering
Sendableissue, update the README and API docs, add Android and Musl CI, fix the tests to not require deterministic hashing, make the tests async, and do some code formatting.While it isn't required for this PR to build, it will not be warnings-free and the Android CI won't pass until vapor/leaf-kit#135 is merged.