Two optimizations: log and allow_llm_to_see_data #454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the usage of
title
in thelog
function withinbase.py
:I noticed that the
title
variable in the log function is not actually used. For example:Add the parameter allow_llm_to_see_data=False to the ask function:
When I ran my code, the terminal displayed the following message:
I checked the parameters of the
ask
function to add this parameter but found that theask
function does not have this parameter.Instead, this parameter is used in the
ask
function'ssql = self.generate_sql(question=question)
section. Therefore, I made this modification.