Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scalabrese] Improved Ollama integration #361

Merged
merged 12 commits into from
Apr 30, 2024

Conversation

scalabreseGD
Copy link
Contributor

  1. Improved Ollama
    a. Added Ollama Python client
    b. Fixed function for SQL extraction
    c. Improved extraction in case of Mistral with squared bracket
    d. Improved extraction making it case insensitive
    e. Pulled the model in case is not existing
    f. Added parameters such as keep_alive, num_ctx and additional parameters to be passed to the ollama server
  2. Added Ollama as extra dependency

@zainhoda
Copy link
Contributor

Thanks @scalabreseGD ! This is looking pretty good. One thing I've been encountering is that if model is set to something like mistral, the model_lists contains mistral:latest, so it pulls the model on every call. Do you have any thoughts on the best way to handle that?

@scalabreseGD
Copy link
Contributor Author

@zainhoda changed the codebase pulling it only at the startup. Is not necessary to check it every time :)

@zainhoda zainhoda merged commit 0703021 into vanna-ai:main Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants