ExecFuncStringWithErr will not panick when f call returns error

[caibirdme]

ExecFuncString will panic if f call returns an error. But panic isn't a good choice, why not just return that error to user? To avoid unexpected panic, user must recover before calling ExecFuncString, this is a hidden requirement to call ExecFuncString.

For the sake of not breaking the compatibility, I added two new method called ExecFuncStringWithErr, which will not panic when f get an error, just returns an empty string and that error directly

[valyala]

Could you also substitute function bodies for already existing ExecuteFuncString functions with the corresponding calls to ExecuteFuncStingWithErr?

[valyala]

ExecuteFuncString -> ExecuteFuncStringWithErr

[caibirdme]

Could you also substitute function bodies for already existing ExecuteFuncString functions with the corresponding calls to ExecuteFuncStingWithErr?

You mean making the existing ExecuteFuncString don't panic anymore?
I've already added a ExecuteFuncStingWithErr and t.ExecuteFuncStingWithErr, I think these may be enough to use

[valyala]

You mean making the existing ExecuteFuncString don't panic anymore?

No, I mean calling *WithErr functions from there and panic on errors. This should reduce code duplication.

[caibirdme]

You mean making the existing ExecuteFuncString don't panic anymore?

No, I mean calling *WithErr functions from there and panic on errors. This should reduce code duplication.

Oh, I get it!

[caibirdme]

@valyala Done

[valyala]

LGTM

[valyala]

@caibirdme , thanks for the contribution!