feat(rating): add aria-label attribute and rating config #5607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #5607 +/- ##
============================================
Coverage 52.52% 52.52%
============================================
Files 3 3
Lines 99 99
Branches 17 17
============================================
Hits 52 52
Misses 37 37
Partials 10 10Continue to review full report at Codecov.
|
daniloff200
previously approved these changes
Jan 21, 2020
valorkin
requested changes
Jan 23, 2020
src/rating/rating.component.ts
Outdated
| @@ -30,6 +30,8 @@ export class RatingComponent implements ControlValueAccessor, OnInit { | |||
| @Input() readonly: boolean; | |||
| /** array of icons titles, default: (["one", "two", "three", "four", "five"]) */ | |||
| @Input() titles: string[]; | |||
| /** custom aria label, default "rating" */ | |||
| @Input() ariaLabel = 'rating'; | |||
There was a problem hiding this comment.
@valorkin I've added Config functionality, could you please re-check my PR?
valorkin
changed the title
valorkin
changed the title
IraErshova
force-pushed
the
fix-rating-add-aria-label
branch
from
7fcfe50 to
6a84444
Compare
Add aria label attribute Add RatingConfig class Close valor-software#5579
IraErshova
force-pushed
the
fix-rating-add-aria-label
branch
from
6a84444 to
f0e7c1b
Compare
|
Tested, Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aria label attribute
Close #5579
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.