Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rating component missing aria-label #5579

Closed
shainanigans opened this issue Dec 24, 2019 · 3 comments · Fixed by #5607
Closed

Rating component missing aria-label #5579

shainanigans opened this issue Dec 24, 2019 · 3 comments · Fixed by #5607
Assignees
@IraErshova
Labels
comp(rating) enhancement

Comments

@shainanigans
Copy link

shainanigans commented Dec 24, 2019 •
edited
Loading

Bug description:
The rating component is missing an aria-label attribute on the span with role="slider". This was discovered using the axe Chrome extension. More information about the issue can be found here.

Example:
Inspecting the demo in the docs, you can see the issue with the aforementioned span element.

Expected behavior
The element should have an aria-label attribute on it. Ideally, this would be an input so that developers can add the most informative label for their use case.
@shainanigans
Copy link
Author

Hi, could someone please address this issue?

@IraErshova
Copy link
Contributor

@shainanigans Thanks for your issue. I'm going to start working on it right now!

@shainanigans
Copy link
Author

Thanks @IraErshova !

IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Jan 21, 2020
@IraErshova
fix(rating): add aria-label attribute
7fcfe50 
Add aria label attribute

Close valor-software#5579
@IraErshova IraErshova mentioned this issue Jan 21, 2020
Merged
5 tasks
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Jan 24, 2020
@IraErshova
feat(rating): add aria-label attribute
6a84444 
Add aria label attribute
Add RatingConfig class

Close valor-software#5579
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Jan 24, 2020
@IraErshova
feat(rating): add aria-label attribute
f0e7c1b 
Add aria label attribute
Add RatingConfig class

Close valor-software#5579
daniloff200 added a commit that referenced this issue Jan 24, 2020
@IraErshova @daniloff200
feat(rating): add aria-label attribute (#5607)
5d505ea 
Add aria label attribute
Add RatingConfig class

Close #5579

Co-authored-by: Dmitriy Danilov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IraErshova IraErshova

Labels
comp(rating) enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rating): add aria-label attribute and rating config IraErshova/ngx-bootstrap
3 participants
@daniloff200 @IraErshova @shainanigans