-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal created via ModalService is not hidden after calling .hide() #3711
Comments
This is still an issue with Setting the option |
Any progress, in which version will be this fixed ? |
@Roman-Simik Fix is now in testing |
Which version was this fixed in? I see the same issue in 8.x. Looks like this issue might have been re-introduced #6195 |
how about using bsModalService .hide() function? will it better? so we still use animation and the modal will be hidden. Edit: I just realized, ngx-bootstrap documentation doesn't inform this function. I saw the library code, there is .hide() function inside BsModalService class. |
Bug description or feature request:
Calling the hide() function on a modal will not hide it if it's not shown fully. This means that if I open a dialog to signal a usually long loading server call which finishes too fast (faster than the modal animation) the hide() will be called but has no effect. You can see this in my demo with three manual delays. At no or small delays the dialog just stays open, at 150ms it isn't even shown properly and at 250ms it works as expected. Another interesting behaviour is that opening many dialogs and closing them fast will leave the GUI unclickable (E.g. in my demo by clicking and holding ctrl+2).
Plunker/StackBlitz that reproduces the issue:
StackBlitz: https://stackblitz.com/edit/ngx-bootstrap-ftrzc4?file=app%2Fapp.component.ts
Versions of ngx-bootstrap, Angular, and Bootstrap:
ngx-bootstrap: 2.0.2
Angular: 4.4.6
Bootstrap: 3.3.7
Build system: Angular Starter (Webpack and SystemJS)
The text was updated successfully, but these errors were encountered: