Skip to content

Commit

Permalink
Merge branch 'development' into feat-time-picker-display-utc
Browse files Browse the repository at this point in the history
  • Loading branch information
daniloff200 authored Jan 17, 2022
2 parents 6c04658 + 58a6e00 commit 6343ebe
Show file tree
Hide file tree
Showing 91 changed files with 701 additions and 741 deletions.
63 changes: 27 additions & 36 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,55 +1,46 @@
# [8.0.0-RC.3](https://github.com/valor-software/ngx-bootstrap/compare/v8.0.0-RC.2...v8.0.0-RC.3) (2021-12-24)
# [8.0.0](https://github.com/valor-software/ngx-bootstrap/compare/v8.0.0-RC.9...v8.0.0) (2022-01-14)

Most notable changes for v8 release:
- added support for **Angular v13**, while still compatible with Angular v12, if your application is compiled in ivy mode
- in v7.1 we have added a support for **Bootstrap 5** and in v8 it has become the default, you are able to continue use **Bootstrap 4** if needed
- support for **Bootstrap 3** has been discontinued, however it may still be usable with v8, there are no guarantees it will work as expected, and is not suggested
- the old datepicker which was deprecated since v6 version was removed for good, please use `BsDatepicker`
- and last but not least, hopefully you are enjoying the new look of our documentation

### Bug Fixes

* **core:** updated peer deps and added license mentions of secondary entry points (fixes [#6371](https://github.com/valor-software/ngx-bootstrap/issues/6371)) ([dfb957f](https://github.com/valor-software/ngx-bootstrap/commit/dfb957f382b51ea99890354b58c35345cca7158f))
* **popover:** added a space between containerClass and checkMarginNecessity() ([#6352](https://github.com/valor-software/ngx-bootstrap/issues/6352)) ([757292b](https://github.com/valor-software/ngx-bootstrap/commit/757292b301ce47ce1802bde560c7498efbee4b61))


### Features

* **datepicker:** add Spanish (Puerto Rico) [es-pr] locale ([#6374](https://github.com/valor-software/ngx-bootstrap/issues/6374)) ([13a4b92](https://github.com/valor-software/ngx-bootstrap/commit/13a4b92133746b36a93e54e680391e60b1273aa5))
* **datepicker:** BREAKING CHANGE dropped old version of datepicker ([#6391](https://github.com/valor-software/ngx-bootstrap/issues/6391)) ([85f56bb](https://github.com/valor-software/ngx-bootstrap/commit/85f56bb08ae865d89e26fa6a01cf558a3693bc62))



# [8.0.0-RC.2](https://github.com/valor-software/ngx-bootstrap/compare/v8.0.0-RC.1...v8.0.0-RC.2) (2021-12-23)



# [8.0.0-RC.1](https://github.com/valor-software/ngx-bootstrap/compare/v8.0.0-RC.2...v8.0.0-RC.1) (2021-12-23)


### Features
Like, Subscribe, Stay tuned ;)

* **documentation:** updated use-cases ([#6360](https://github.com/valor-software/ngx-bootstrap/issues/6360)) ([fa365cf](https://github.com/valor-software/ngx-bootstrap/commit/fa365cf1bd7e56a0b4824b586c997a86ce5b4307)), closes [#6359](https://github.com/valor-software/ngx-bootstrap/issues/6359)
Regards, @valorkin

### BREAKING CHANGES

* **datepicker:** dropped old version of datepicker ([#6391](https://github.com/valor-software/ngx-bootstrap/issues/6391)) ([85f56bb](https://github.com/valor-software/ngx-bootstrap/commit/85f56bb08ae865d89e26fa6a01cf558a3693bc62))

# [8.0.0-RC.2](https://github.com/valor-software/ngx-bootstrap/compare/v8.0.0-RC.1...v8.0.0-RC.2) (2021-12-20)
* **bootstrap:** bs5 set as default ([#6405](https://github.com/valor-software/ngx-bootstrap/issues/6405)) ([7849793](https://github.com/valor-software/ngx-bootstrap/commit/78497930c8f9e42ce91ae546b7d5560369781184))


### Bug Fixes

* **datepicker:** fixed error while cleaning input for daterangepicker ([#6407](https://github.com/valor-software/ngx-bootstrap/issues/6407)) ([fc5f05c](https://github.com/valor-software/ngx-bootstrap/commit/fc5f05c4adbe44157b212b0e9c5598c2b95d0a80))
* **datepicker:** fixed clear button in datepicker ([#6338](https://github.com/valor-software/ngx-bootstrap/issues/6338)) ([12e050f](https://github.com/valor-software/ngx-bootstrap/commit/12e050fab9b002169051a363a9fe2dc22edbdecc))
* **datepicker:** fixed inline datepicker subscriptions ([#6339](https://github.com/valor-software/ngx-bootstrap/issues/6339)) ([2e85bac](https://github.com/valor-software/ngx-bootstrap/commit/2e85bac1c5f77a6ca61f9fce7a75a67a42c1b609))
* **datepicker:** fixed enabled/diabled dates ([#6355](https://github.com/valor-software/ngx-bootstrap/issues/6355)) ([f247b18](https://github.com/valor-software/ngx-bootstrap/commit/f247b187d67eb664dc44b759acde2595a20cf69c))
* **progressbar:** fixed error Cannot read properties of undefined (reading 'currentValue') ([#6409](https://github.com/valor-software/ngx-bootstrap/issues/6409)) ([df7bdba](https://github.com/valor-software/ngx-bootstrap/commit/df7bdba9f0c23be4024d9ff7524094122ffadba2))
* **typeahead:** fixed exports of typeahead lib ([#6402](https://github.com/valor-software/ngx-bootstrap/issues/6402)) ([fbe749c](https://github.com/valor-software/ngx-bootstrap/commit/fbe749cbae3914178ea80d4e3e1506ca308b7815))
* **component-loader:** don't remove elemenent if component is detached fix [#6358](https://github.com/valor-software/ngx-bootstrap/issues/6358) ([425db25](https://github.com/valor-software/ngx-bootstrap/commit/425db25796b504d1a2967dc6a45c860821f79799))
* **build:** add manual exports for root package ([136a85e](https://github.com/valor-software/ngx-bootstrap/commit/136a85e05b78cd6104a6a96d58388782dcc731bb))
* **core:** updated peer deps and added license mentions of secondary entry points (fixes [#6371](https://github.com/valor-software/ngx-bootstrap/issues/6371)) ([dfb957f](https://github.com/valor-software/ngx-bootstrap/commit/dfb957f382b51ea99890354b58c35345cca7158f))
* **popover:** added a space between containerClass and checkMarginNecessity() ([#6352](https://github.com/valor-software/ngx-bootstrap/issues/6352)) ([757292b](https://github.com/valor-software/ngx-bootstrap/commit/757292b301ce47ce1802bde560c7498efbee4b61))
* **build:** change build folder structure in order to work properly with nx 13 ([8bfbfa5](https://github.com/valor-software/ngx-bootstrap/commit/8bfbfa568f7eeac718438885c3003ea1c1d6f563))



# [8.0.0-RC.1](https://github.com/valor-software/ngx-bootstrap/compare/v8.0.0-RC.0...v8.0.0-RC.1) (2021-12-20)


### Bug Fixes

* **build:** fix api docs api generation ([c275900](https://github.com/valor-software/ngx-bootstrap/commit/c275900ae7151eb56b2ab3308f278be47b2c15e8))



# [8.0.0-RC.0](https://github.com/valor-software/ngx-bootstrap/compare/v7.1.2...v8.0.0-RC.0) (2021-12-16)


### Features

* **datepicker:** prevent overflow if adaptivePosition is set to true ([#6408](https://github.com/valor-software/ngx-bootstrap/issues/6408)) ([a43f6c2](https://github.com/valor-software/ngx-bootstrap/commit/a43f6c25c977e43a04162d1cd16937c06a595184))
* **schematics:** change Bootstrap version to 5 ([cf39d34](https://github.com/valor-software/ngx-bootstrap/commit/cf39d348f34318ce403edad3de1f751cd8a90165))
* **datepicker:** add Spanish (Puerto Rico) [es-pr] locale ([#6374](https://github.com/valor-software/ngx-bootstrap/issues/6374)) ([13a4b92](https://github.com/valor-software/ngx-bootstrap/commit/13a4b92133746b36a93e54e680391e60b1273aa5))
* **datepicker:** BREAKING CHANGE dropped old version of datepicker ([#6391](https://github.com/valor-software/ngx-bootstrap/issues/6391)) ([85f56bb](https://github.com/valor-software/ngx-bootstrap/commit/85f56bb08ae865d89e26fa6a01cf558a3693bc62))
* **documentation:** updated use-cases ([#6360](https://github.com/valor-software/ngx-bootstrap/issues/6360)) ([fa365cf](https://github.com/valor-software/ngx-bootstrap/commit/fa365cf1bd7e56a0b4824b586c997a86ce5b4307)), closes [#6359](https://github.com/valor-software/ngx-bootstrap/issues/6359)
* **documentation:** Documentation UI update ([#6305](https://github.com/valor-software/ngx-bootstrap/issues/6305)) ([bd81f14](https://github.com/valor-software/ngx-bootstrap/commit/bd81f14ca80fbdd5a845f828496f2ebe1efa4981)), closes [#6364](https://github.com/valor-software/ngx-bootstrap/issues/6364)


Expand Down
23 changes: 12 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,17 +154,18 @@ npm start
The only two dependencies are [Angular](https://angular.io) and [Bootstrap](https://getbootstrap.com) CSS.
Here is the versions compatibility list:

| ngx-bootstrap | Angular | Bootstrap CSS |
| ------------- | ------------- | -------------- |
| 7.1.0 | 11.x.x - 12.x.x | 5.x.x 4.x.x or 3.x.x |
| 7.0.0 | 11.x.x - 12.x.x | 3.x.x or 4.x.x |
| 6.0.0 | 9.x.x - 10.x.x | 3.x.x or 4.x.x |
| 5.6.x | 7.x.x - 9.1.0 | 3.x.x or 4.x.x |
| 5.0.0 - 5.6.0 | 7.x.x - 8.x.x | 3.x.x or 4.x.x |
| 4.x.x | 6.x.x - 7.x.x | 3.x.x or 4.x.x |
| 3.x.x | 6.x.x - 7.x.x | 3.x.x or 4.x.x |
| 2.x.x | 2.x.x - 4.x.x | 3.x.x or 4.x.x |
| 1.x.x | 2.x.x | 3.x.x or 4.x.x |
| ngx-bootstrap | Angular | Bootstrap CSS |
|---------------|-----------------|-------------------------|
| 8.0.0 | 12.x.x - 13.x.x | 5.x.x or 4.x.x or 3.x.x |
| 7.1.0 | 11.x.x - 12.x.x | 5.x.x or 4.x.x or 3.x.x |
| 7.0.0 | 11.x.x - 12.x.x | 3.x.x or 4.x.x |
| 6.0.0 | 9.x.x - 10.x.x | 3.x.x or 4.x.x |
| 5.6.x | 7.x.x - 9.1.0 | 3.x.x or 4.x.x |
| 5.0.0 - 5.6.0 | 7.x.x - 8.x.x | 3.x.x or 4.x.x |
| 4.x.x | 6.x.x - 7.x.x | 3.x.x or 4.x.x |
| 3.x.x | 6.x.x - 7.x.x | 3.x.x or 4.x.x |
| 2.x.x | 2.x.x - 4.x.x | 3.x.x or 4.x.x |
| 1.x.x | 2.x.x | 3.x.x or 4.x.x |


## Troubleshooting
Expand Down
3 changes: 1 addition & 2 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -1304,8 +1304,7 @@
"commands": [
"ts-node ./scripts/set-version.ts",
"conventional-changelog --preset angular --infile CHANGELOG.md --same-file --release-count 1",
"git add -A",
"git commit -am \"chore(changelog): update [skip ci] \""
"git add -A"
],
"parallel": false
},
Expand Down
3 changes: 2 additions & 1 deletion apps/ngx-bootstrap-docs-e2e/cypress-full.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@
"screenshotsFolder": "../../dist/cypress/apps/ngx-bootstrap-docs-e2e/screenshots",
"chromeWebSecurity": false,
"responseTimeout": 60000,
"pageLoadTimeout": 120000
"pageLoadTimeout": 120000,
"scrollBehavior": "center"
}
3 changes: 2 additions & 1 deletion apps/ngx-bootstrap-docs-e2e/cypress.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@
"screenshotsFolder": "../../dist/cypress/apps/ngx-bootstrap-docs-e2e/screenshots",
"chromeWebSecurity": false,
"responseTimeout": 60000,
"pageLoadTimeout": 120000
"pageLoadTimeout": 120000,
"scrollBehavior": "center"
}
6 changes: 3 additions & 3 deletions apps/ngx-bootstrap-docs-e2e/src/full/alerts_page_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ describe('Alerts page testing suite', () => {
alerts.isAlertVisible(dismissing, 'success');
alerts.isAlertVisible(dismissing, 'info');
alerts.isAlertVisible(dismissing, 'danger');
alerts.isButtonExist(dismissing, '×Close', 0, false);
alerts.isButtonExist(dismissing, '×Close', 1, false);
alerts.isButtonExist(dismissing, '×Close', 2, false);
alerts.IsButtonDisappeared(dismissing, '×Close');
alerts.IsButtonDisappeared(dismissing, '×Close');
alerts.IsButtonDisappeared(dismissing, '×Close');
});

it(`when user click "Toggle dismissible" again, then close buttons appeared`, () => {
Expand Down
26 changes: 14 additions & 12 deletions apps/ngx-bootstrap-docs-e2e/src/full/carousel_page_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ describe('Carousel page testing suite', () => {

describe('Dynamic Slides ', () => {
const dynamicSlides = carousel.exampleDemosArr.dynamicSlides;
const dynamicSlidesControlBtns = carousel.exampleDemosArr.dynamicSlidesControlBtns;

it('example contains slides, indicators, left and right controls and captions', () => {
carousel.scrollToMenu('Dynamic Slides');
Expand All @@ -73,37 +74,37 @@ describe('Carousel page testing suite', () => {

it('example contains 3 additional buttons: "Add Slide", "Remove Current", "Remove #3"', () => {
carousel.scrollToMenu('Dynamic Slides');
carousel.isBtnTxtEqual(dynamicSlides, 'Add Slide ', 0);
carousel.isBtnTxtEqual(dynamicSlides, 'Remove Current ', 1);
carousel.isBtnTxtEqual(dynamicSlides, 'Remove #3 ', 2);
carousel.isBtnTxtEqual(dynamicSlidesControlBtns, 'Add Slide ', 0);
carousel.isBtnTxtEqual(dynamicSlidesControlBtns, 'Remove Current ', 1);
carousel.isBtnTxtEqual(dynamicSlidesControlBtns, 'Remove #3 ', 2);
});

it('when user click on "Add Slide", then amount of slides increased at 1 with header and info', () => {
carousel.scrollToMenu('Dynamic Slides');
carousel.isSlidesCountEqual(dynamicSlides, 4);
carousel.clickOnBtn(dynamicSlides, 0);
carousel.clickOnBtn(dynamicSlidesControlBtns, 0);
carousel.isSlidesCountEqual(dynamicSlides, 5);
carousel.clickOnBtn(dynamicSlides, 0);
carousel.clickOnBtn(dynamicSlidesControlBtns, 0);
carousel.isSlidesCountEqual(dynamicSlides, 6);
});

it('when user click on "Remove Current", then amount of slides decreased at 1 and current slide deleted', () => {
carousel.scrollToMenu('Dynamic Slides');
carousel.isSlidesCountEqual(dynamicSlides, 4);
carousel.clickOnBtn(dynamicSlides, 1);
carousel.clickOnBtn(dynamicSlidesControlBtns, 1);
carousel.isSlidesCountEqual(dynamicSlides, 3);
carousel.clickOnBtn(dynamicSlides, 1);
carousel.clickOnBtn(dynamicSlidesControlBtns, 1);
carousel.isSlidesCountEqual(dynamicSlides, 2);
});

it('when user click on "Remove #3" - then third slide deleted', () => {
carousel.scrollToMenu('Dynamic Slides');
carousel.isSlidesCountEqual(dynamicSlides, 4);
carousel.clickOnBtn(dynamicSlides, 2);
carousel.clickOnBtn(dynamicSlidesControlBtns, 2);
carousel.isSlidesCountEqual(dynamicSlides, 3);
carousel.clickOnBtn(dynamicSlides, 2);
carousel.clickOnBtn(dynamicSlidesControlBtns, 2);
carousel.isSlidesCountEqual(dynamicSlides, 2);
carousel.clickOnBtn(dynamicSlides, 2);
carousel.clickOnBtn(dynamicSlidesControlBtns, 2);
carousel.isSlidesCountEqual(dynamicSlides, 2);
});

Expand Down Expand Up @@ -183,15 +184,16 @@ describe('Carousel page testing suite', () => {

describe('Disable indicator ', () => {
const disableIndicatorSlides = carousel.exampleDemosArr.disableIndicator;
const controlBtnDisableIndicator = carousel.exampleDemosArr.controlBtnDisableIndicator;

it('example contains slides, indicators, left and right controls and "Enable/Disable" button', () => {
carousel.scrollToMenu('Disable indicator');
carousel.isCarouselHaveIndicatorsItemsCtrls(disableIndicatorSlides);
carousel.isBtnTxtEqual(disableIndicatorSlides, 'Enable/Disable Indicator ');
carousel.isBtnTxtEqual(controlBtnDisableIndicator, 'Enable/Disable Indicator ');
});
it('when user click on "Enable/Disable Indicator" - indicator disappeared', () => {
carousel.scrollToMenu('Disable indicator');
carousel.clickOnBtn(disableIndicatorSlides);
carousel.clickOnBtn(controlBtnDisableIndicator);
carousel.isCarouselIndicatorDisabled(disableIndicatorSlides, true);
});
it('when user click on "Enable/Disable Indicator" again - indicator appeared', () => {
Expand Down
2 changes: 1 addition & 1 deletion apps/ngx-bootstrap-docs-e2e/src/full/collapse_page_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ describe('Collapse demo page testing suite', () => {

it('when user clicks on "Inline-block", then collapse appear with inline-block, on "None" - without inline', () => {
collapse.clickOnBtn(inlineDisplay, 0);
collapse.isCollapseExpanded(inlineDisplay, 'false');
collapse.isCollapseExpanded(inlineDisplay, 'true');
collapse.isCollapseWithInline(inlineDisplay, true);

collapse.clickOnBtn(inlineDisplay, 1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('Modals demo page testing suite: Directive examples', () => {
it('when user clicks on the cross button then the modal is closed', () => {
modals.clickByText(staticModalDemo, btnText);
modals.isModalVisible(modals.modalDialog, true);
modals.clickByText(modals.modalBtnX, btnX);
modals.clickCloseBtn(staticModalDemo);
modals.isModalEnabled(modals.modalDialog, false);
});
});
Expand Down Expand Up @@ -155,7 +155,7 @@ describe('Modals demo page testing suite: Directive examples', () => {
it(`when user closes modal by click on the cross then should be messages "event onHide is fired"
and "event onHidden is fired"`, () => {
modals.clickByText(eventsModalsDemo, btnText);
modals.clickByText(modals.modalBtnX, btnX);
modals.clickCloseBtn(eventsModalsDemo);
modals.isDemoContainsTxt(eventsModalsDemo, eventOnHide);
modals.isDemoContainsTxt(eventsModalsDemo, eventOnHidden);
});
Expand Down Expand Up @@ -203,7 +203,7 @@ describe('Modals demo page testing suite: Directive examples', () => {
it(`when user closes the modal then modal is removed from the DOM`,
() => {
modals.clickByText(autoDemo, btnText);
modals.clickByText(modals.modalBtnX, btnX);
modals.clickCloseBtn(autoDemo);
modals.isModalEnabled(autoDemo, false);
});
});
Expand Down
10 changes: 5 additions & 5 deletions apps/ngx-bootstrap-docs-e2e/src/full/modals_service_page_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ describe('Modals demo page testing suite: Service examples', () => {
it(`when user closes modal by click on the cross then should be messages "onHide event has been fired"
and "onHidden event has been fired"`, () => {
modals.clickByText(eventsDemo, btnText);
modals.clickByText(modals.modalBtnX, btnX);
modals.clickCloseBtn(`modal-container .modal-header`);
modals.isModalEnabled(modals.modalContainer, false);
modals.isDemoContainsTxt(eventsDemo, demoOnHideFired);
modals.isDemoContainsTxt(eventsDemo, demoOnHideFired);
Expand Down Expand Up @@ -256,7 +256,7 @@ describe('Modals demo page testing suite: Service examples', () => {

it('when user clicks on the cross button then the modal is closed', () => {
modals.clickByText(customCSSDemo, btnText);
modals.clickByText(modals.modalBtnX, btnX);
modals.clickCloseBtn(customCSSDemo);
modals.isModalEnabled(modals.modalContainer, false);
});
});
Expand Down Expand Up @@ -293,7 +293,7 @@ describe('Modals demo page testing suite: Service examples', () => {

it('when user clicks on the cross button then the modal is closed', () => {
modals.clickByText(animationDemo, btnText);
modals.clickByText(modals.modalBtnX, btnX);
modals.clickCloseBtn(animationDemo);
modals.isModalEnabled(modals.modalContainer, false);
});
});
Expand All @@ -315,7 +315,7 @@ describe('Modals demo page testing suite: Service examples', () => {
ESC button then modal stays opened`, () => {
modals.clickByText(escapeDemo, btnDisable);
modals.clickByText(escapeDemo, btnText);
modals.pressEsc();
modals.pressEscModal();
modals.isModalVisible(modals.modalContainer, true);
});

Expand All @@ -328,7 +328,7 @@ describe('Modals demo page testing suite: Service examples', () => {
it(`after that click on "Open modal" button, modal popup is opened. when user press ESC button then modal
is closed`, () => {
modals.clickByText(escapeDemo, btnText);
modals.pressEsc();
modals.pressEscModal();
modals.isModalEnabled(modals.modalContainer, false);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,7 @@ describe('Pagination demo page testing suite', () => {
pagination.clickOnDemoMenu('Pager');
pagination.isPaginationLengthEqual(pager, 7);
pagination.isActivePositionEqual(pager, '4');
console.log('!!!!!!!!!!!!', pager);
pagination.isPagerDisabled(pager, 'Previous', false);
pagination.isPagerDisabled(pager, 'Next', false);
});
Expand Down
Loading

0 comments on commit 6343ebe

Please sign in to comment.