Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve header menu blog + connect #149

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Improve header menu blog + connect #149

merged 2 commits into from
Oct 4, 2024

Conversation

melroy89
Copy link
Contributor

@melroy89 melroy89 commented Oct 3, 2024 •
edited
Loading

Description

  • Move blog to a dedicated menu item at top level, so people can much easier find it (also it's not really "community", its just a blog)
  • Under Community I now also added 'Connect'
  • Open github.com link in new tab

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@melroy89
Improve header menu blog + connect
9d2764a 
Signed-off-by: Melroy van den Berg <[email protected]>
@melroy89
Open GitHub page in new tab
723649a 
Signed-off-by: Melroy van den Berg <[email protected]>
stockholmux
stockholmux approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@stockholmux stockholmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stockholmux
Copy link
Member

I have no issue with this, seems to work in all resolutions. WDYT @madolson?

Screenshot 2024-10-03 at 2 22 56 PM Screenshot 2024-10-03 at 2 22 42 PM Screenshot 2024-10-03 at 2 22 31 PM

madolson
madolson approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@stockholmux stockholmux merged commit 93a1744 into valkey-io:main Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stockholmux stockholmux stockholmux approved these changes

@madolson madolson madolson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melroy89 @stockholmux @madolson