Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add AzAffinity Support #3235

Merged
merged 9 commits into from
Mar 4, 2025
Merged

Go: Add AzAffinity Support #3235

merged 9 commits into from
Mar 4, 2025

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Feb 22, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #3267

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@tjzhang-BQ tjzhang-BQ added the go golang wrapper label Feb 22, 2025
Go: Add AzAffinity Support
e48d315 
Signed-off-by: TJ Zhang <[email protected]>
@jbrinkman
Copy link
Collaborator

Please update the description with an Issue Number, and update the checklist as appropriate.

adding tests
c164df9 
Signed-off-by: TJ Zhang <[email protected]>
changelog
c7ba393 
Signed-off-by: TJ Zhang <[email protected]>
@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review February 26, 2025 06:46
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner February 26, 2025 06:47
removing unneeded prints
0d4237f 
Signed-off-by: TJ Zhang <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Feb 27, 2025
View reviewed changes
removing panicking logic
82e40db 
Signed-off-by: TJ Zhang <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Feb 28, 2025
View reviewed changes
TJ Zhang and others added 2 commits March 3, 2025 23:05
jbrinkman
jbrinkman approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

yipin-chen
yipin-chen approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjzhang-BQ tjzhang-BQ merged commit 13f91b1 into main Mar 4, 2025
17 of 18 checks passed
@tjzhang-BQ tjzhang-BQ deleted the go/tjz-azaffinity branch March 4, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@jbrinkman jbrinkman jbrinkman approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

@adarovadya adarovadya Awaiting requested review from adarovadya

@Muhammad-awawdi-amazon Muhammad-awawdi-amazon Awaiting requested review from Muhammad-awawdi-amazon

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjzhang-BQ @jbrinkman @Yury-Fridlyand @yipin-chen