Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor routes. #3176

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Refactor routes. #3176

merged 4 commits into from
Feb 14, 2025

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Feb 14, 2025 •
edited
Loading

  1. Move all logic from ToRoutesProtobuf to another place, so this API was removed
  2. Fix corresponding UTs and move them to the right place
  3. Remove unused dbsize option (was replaced by RouteOption before)

@Yury-Fridlyand
Refactor routes.
6c786d3 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Refactor routes.
51dc629 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Feb 14, 2025
@Yury-Fridlyand Yury-Fridlyand added this to the 1.3 milestone Feb 14, 2025
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner February 14, 2025 19:39
@Yury-Fridlyand
Refactor routes.
bb9df7f 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
lint
0a287c0 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand merged commit 247716c into valkey-io:release-1.3 Feb 14, 2025
18 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the go/refactor-3 branch February 14, 2025 21:18
@yipin-chen yipin-chen mentioned this pull request Feb 18, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @yipin-chen @prateek-kumar-improving