Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Fix NPM CD tag on release-1.3 #3163

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Node: Fix NPM CD tag on release-1.3 #3163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caab299
Node: Fix NPM CD tag on release-1.3
jamesx-improving Feb 13, 2025
5ed99ab
CHANGELOG
jamesx-improving Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/npm-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,20 +166,20 @@ jobs:
- name: Check if RC and set a distribution tag for the package
shell: bash
run: |
if [[ "${GITHUB_REF:11}" == *"rc"* ]]
if [[ "${RELEASE_VERSION}" == *"rc"* ]]
then
echo "This is a release candidate: ${GITHUB_REF:11}"
echo "This is a release candidate: ${RELEASE_VERSION}"
export npm_tag="next"
else
echo "This is a stable release: ${GITHUB_REF:11}"
echo "This is a stable release: ${RELEASE_VERSION}"
export npm_tag="latest"
fi
echo "NPM_TAG=${npm_tag}" >> $GITHUB_ENV

- name: Check that the release version dont have typo init
if: ${{ github.event_name != 'pull_request' && contains(env.RELEASE_VERSION, '-') && !contains(env.RELEASE_VERSION, 'rc') }}
run: |
echo "The release version "${GITHUB_REF:11}" contains a typo, please fix it"
echo "The release version "${RELEASE_VERSION}" contains a typo, please fix it"
echo "The release version should be in the format v{major-version}.{minor-version}.{patch-version}-rc{release-candidate-number} when it a release candidate or v{major-version}.{minor-version}.{patch-version} in a stable release."
exit 1

Expand Down Expand Up @@ -371,7 +371,7 @@ jobs:
- name: Check if RC and set a distribution tag for the package
shell: bash
run: |
if [[ "${GITHUB_REF:11}" == *"rc"* ]]
if [[ "${RELEASE_VERSION}" == *"rc"* ]]
then
echo "This is a release candidate"
export npm_tag="next"
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
* Core: improve fix in #2381 ([#2929](https://github.com/valkey-io/valkey-glide/pull/2929))
* Java: Fix `lpopCount` null handling ([#3025](https://github.com/valkey-io/valkey-glide/pull/3025))
* Core: Fix `opentelemetry` related dependency issue (backport to 1.3) ([#3130](https://github.com/valkey-io/valkey-glide/pull/3130))
* Node: Fix NPM CD tag ([#3163](https://github.com/valkey-io/valkey-glide/pull/3163))

#### Operational Enhancements

Expand Down
Loading