Node: add AZAffinityReplicasAndPrimary ReadFrom strategy support #3063
+110
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammad Awawdi <[email protected]>
Signed-off-by: Muhammad Awawdi <[email protected]>
adarovadya
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Seems you need to add the strategy to ReadFrom- https://github.com/valkey-io/valkey-glide/blob/main/node/src/BaseClient.ts#L496-L504
|
@adarovadya it was added inside the Core PR. its a bit misleading, but yes, its there 😄 |
adarovadya
approved these changes
Feb 4, 2025
Muhammad-awawdi-amazon
merged commit f8abf16
into
valkey-io:release-1.3
19 checks passed
Muhammad-awawdi-amazon
deleted the
node-azaffinityreplicasandprimary-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2792
Checklist
Before submitting the PR make sure the following are checked: