Merge from redis-rs and fixes for rust 1.80.0 #2029
Conversation
Signed-off-by: barshaul <[email protected]>
Signed-off-by: barshaul <[email protected]>
| @@ -13,7 +13,7 @@ test-env-helpers = "0.2.2" | |||
|
|
|||
| [dependencies] | |||
| tracing = "0.1" | |||
| tracing-appender = "0.2.2" | |||
| tracing-appender = { version = "0.2.3", default-features = false } | |||
There was a problem hiding this comment.
Did you check if it has any implication to the behavior, does the features connected to our usage in some way?
Generally for faster builds we should disable default feature everywhere.
We'll not go all over the packages now (for redis-rs ill do it at some point) but let's try to make sure we do that when adding new packages.
There was a problem hiding this comment.
there's no implications
https://github.com/tokio-rs/tracing/blob/master/tracing-appender/Cargo.toml
| @@ -30,6 +30,7 @@ nanoid = "0.4.0" | |||
|
|
|||
| [features] | |||
| socket-layer = ["directories", "integer-encoding", "num_cpus", "protobuf", "tokio-util"] | |||
| standalone_heartbeat = [] | |||
There was a problem hiding this comment.
What is the Idea of this feature?
There was a problem hiding this comment.
it's a standalone feature to run heartbeats on the connections which we decided not to enable yet, this is why it's behind a feature flag.
|
Can you please mention what's the upstream merge include? |
It's mentioned on the PR descriptionn
It's already separated by commits |
Fixes for rust 1.80.0:
Including:
timedependency hardcoded with old version, causing to this build error: regression: type annotations needed for Box<_> rust-lang/rust#127343 (comment)Merge from upstream redis-rs:
Including: