Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article page #15

Merged
merged 37 commits into from
Dec 22, 2021
Merged

Article page #15

merged 37 commits into from
Dec 22, 2021

Conversation

validity-check
Copy link
Owner

@validity-check validity-check commented Dec 17, 2021

Closes #4
Article page in its current form. Few things need to be fixed:

  • It needs to be wrapped in its Layout
  • Author's PFP and Article thumbnails are broken

@validity-check
Copy link
Owner Author

The last few commits fixed the points made in the first comment of the PR. Now, the dynamic article page (for reading an article) needs to be worked on.

@validity-check
Copy link
Owner Author

In hindsight, this PR is too large. This should be taken as a lesson for future PRs.

@validity-check validity-check merged commit 8ea2c87 into master Dec 22, 2021
@validity-check validity-check deleted the article-page branch December 22, 2021 17:04
@validity-check validity-check added the frontend Anything to do with the frontend label Dec 22, 2021
@validity-check validity-check mentioned this pull request Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Anything to do with the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create blog page
1 participant