feat(isBtcAddress): ✨ Support all address formats and testnets #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubiin
approved these changes
May 29, 2024
profnandaa
approved these changes
Jun 1, 2024
|
Thanks for your contrib! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
isBtcAddressvalidator fails validation on the new taproot bitcoin address format (62 characters), as well as testnet addresses.This PR adds support for the testnet prefixes listed in (this article) as well as the new taproot addresses (Bech32m) which are very similar to Bech32.
In addition, the characters
1biowere removed from the regex because they're not part of theBech32alphabet.Let me know what you think !