Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mobile phone validation for pt-br #1671

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −7
Open

Fixed mobile phone validation for pt-br #1671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isMobilePhone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const phones = {
'nl-NL': /^(((\+|00)?31\(0\))|((\+|00)?31)|0)6{1}\d{8}$/,
'nn-NO': /^(\+?47)?[49]\d{7}$/,
'pl-PL': /^(\+?48)? ?[5-8]\d ?\d{3} ?\d{2} ?\d{2}$/,
'pt-BR': /^((\+?55\ ?[1-9]{2}\ ?)|(\+?55\ ?\([1-9]{2}\)\ ?)|(0[1-9]{2}\ ?)|(\([1-9]{2}\)\ ?)|([1-9]{2}\ ?))((\d{4}\-?\d{4})|(9[2-9]{1}\d{3}\-?\d{4}))$/,
'pt-BR': /^((\+?55\ ?[1-9]{2}\ ?)|(\+?55\ ?\([1-9]{2}\)\ ?)|(0[1-9]{2}\ ?)|(\([1-9]{2}\)\ ?)|([1-9]{2}\ ?))((\d{4}\-?\d{4})|(9[1-9]{1}\d{3}\-?\d{4}))$/,
Copy link
Contributor

@fedeci fedeci Oct 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be heavy redoxable, it was also before this PR, however.

'pt-PT': /^(\+?351)?9[1236]\d{7}$/,
'pt-AO': /^(\+244)\d{9}$/,
'ro-RO': /^(\+?4?0)\s?7\d{2}(\/|\s|\.|\-)?\d{3}(\s|\.|\-)?\d{3}$/,
Expand Down
16 changes: 10 additions & 6 deletions test/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5908,12 +5908,15 @@ describe('Validators', () => {
'+55 (15) 97661234',
'55 (17) 96332-2155',
'55 (17) 6332-2155',
'55 (11) 910007890',
'55 15 976612345',
'55 15 75661234',
'+5512984567890',
'+551283456789',
'+5511910007890',
'5512984567890',
'551283456789',
'5511910007890',
'015994569878',
'01593456987',
'022995678947',
Expand All @@ -5927,6 +5930,7 @@ describe('Validators', () => {
'(22) 999567894',
'(22) 99956-7894',
'(11) 94123-4567',
'(11) 91000-7890',
],
invalid: [
'0819876543',
Expand All @@ -5935,12 +5939,12 @@ describe('Validators', () => {
'5501599623874',
'+55012962308',
'+55 015 1234-3214',
'+55 11 91431-4567',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these removed, did you introduce a regression? I can't see it from the code change...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @profnandaa. I've removed because the previous rule was blocking numbers starting with 1 after 9 and those are valid brazilian numbers, so I've replaced for invalid numbers starting with 0 after 9. In this PR from last year it was added, but they aren't invalid numbers.

'+55 (11) 91431-4567',
'+551191431-4567',
'5511914314567',
'5511912345678',
'(11) 91431-4567',
'+55 11 90431-4567',
'+55 (11) 90431-4567',
'+551190431-4567',
'5511904314567',
'5511902345678',
'(11) 90431-4567',
],
},
{
Expand Down