Added isMobile de-AT #1038
Closed
Added isMobile de-AT #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gibbets thanks for raising this PR. I will take a look at this PR and leave my review. |
profnandaa
requested changes
Jun 13, 2019
| @@ -38,9 +38,9 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/cli": "^7.0.0", | |||
| "@babel/core": "^7.0.0", | |||
| "@babel/core": "^7.4.5", | |||
There was a problem hiding this comment.
You can leave out these changes since they are not related to the PR.
profnandaa
added
the
🧹 needs-update
|
Hi, I commited the changes. |
ezkemboi
reviewed
Jun 16, 2019
| @@ -17,6 +17,7 @@ const phones = { | |||
| 'cs-CZ': /^(\+?420)? ?[1-9][0-9]{2} ?[0-9]{3} ?[0-9]{3}$/, | |||
| 'da-DK': /^(\+?45)?\s?\d{2}\s?\d{2}\s?\d{2}\s?\d{2}$/, | |||
| 'de-DE': /^(\+49)?0?1(5[0-25-9]\d|6([23]|0\d?)|7([0-57-9]|6\d))\d{7}$/, | |||
| 'de-AT': /^(\+43)?0?6\d{9}$/, | |||
There was a problem hiding this comment.
I am leaving some comment here based on my research.
I come across these statements
Austrian mobile (Handy) telephone numbers begin with 0650 or higher up to 0699
(eg 0664 plus the rest of the number). Numbers beginning with 0900 are exorbitantly charged and best avoided.
Some large organizations have ‘050’ numbers, which do not need an area code
(a local call from a landline, but more expensive from a mobile phone).
Link
Again, I come to across below
Austria’s country phone code is 43.
There are no standard lengths for either area codes or subscribers’ numbers in Austria,
so some subscribers’ numbers are as short as three digits!
For example, area phone codes can be anywhere from three digits (such as Linz’s 070)
to five digits (such as Kitzbuehel’s 05356);
the telephone numbers range from four to seven digits.
Link for above
I don't know if the statements above are valid. If valid, then it means regex will need some updates.
profnandaa
reviewed
Jun 17, 2019
|
@gibbets -- ping. |
ezkemboi
added a commit
to ezkemboi/validator.js
that referenced
this pull request
Jul 9, 2019
Co-authored-by: Ezrqn Kemboi <[email protected]> closes validatorjs#1038 validatorjs#1028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added local de-AT for isMobile