Merge pull request #672 from michaltk/more-creditcard-validator-fix

Fix credit card validator to only remove dashes and spaces
validatorjs · Jun 29, 2017 · a4d7157 · a4d7157
2 parents 0d9ed49 + 678c39d
commit a4d7157
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/lib/isCreditCard.js b/lib/isCreditCard.js
@@ -17,7 +17,7 @@ var creditCard = /^(?:4[0-9]{12}(?:[0-9]{3})?|5[1-5][0-9]{14}|(222[1-9]|22[3-9][
 
 function isCreditCard(str) {
   (0, _assertString2.default)(str);
-  var sanitized = str.replace(/[^0-9]+/g, '');
+  var sanitized = str.replace(/[- ]+/g, '');
   if (!creditCard.test(sanitized)) {
     return false;
   }

diff --git a/src/lib/isCreditCard.js b/src/lib/isCreditCard.js
@@ -6,7 +6,7 @@ const creditCard = /^(?:4[0-9]{12}(?:[0-9]{3})?|5[1-5][0-9]{14}|(222[1-9]|22[3-9
 
 export default function isCreditCard(str) {
   assertString(str);
-  const sanitized = str.replace(/[^0-9]+/g, '');
+  const sanitized = str.replace(/[- ]+/g, '');
   if (!creditCard.test(sanitized)) {
     return false;
   }

diff --git a/test/validators.js b/test/validators.js
@@ -1816,6 +1816,9 @@ describe('Validators', function () {
         '2220175103860763',
         '375556917985515999999993',
         '899999996234917882863855',
+        'prefix6234917882863855',
+        '623491788middle2863855',
+        '6234917882863855suffix',
       ],
     });
   });

diff --git a/validator.js b/validator.js
@@ -736,7 +736,7 @@ var creditCard = /^(?:4[0-9]{12}(?:[0-9]{3})?|5[1-5][0-9]{14}|(222[1-9]|22[3-9][
 
 function isCreditCard(str) {
   assertString(str);
-  var sanitized = str.replace(/[^0-9]+/g, '');
+  var sanitized = str.replace(/[- ]+/g, '');
   if (!creditCard.test(sanitized)) {
     return false;
   }