Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mozilla bug 1372276 - Remove menuitem. #70

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jun 22, 2022

No description provided.

@emilio
Copy link
Contributor Author

emilio commented Jun 22, 2022

r? @hsivonen

I don't think the build failure is related to my patch, but let me know if that's wrong.

@hsivonen
Copy link
Member

The failure relates to a mismatch of the JSON library version. It seems that it's my fault.

@hsivonen hsivonen self-requested a review June 22, 2022 12:30
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ for landing once the Gecko changeset lands.

@hsivonen
Copy link
Member

I reverted the change from my previous changeset that shouldn't have been there in the first place. It seems, though, that restarting the tests use the base revision that the PR was made from and not the new trunk.

@emilio
Copy link
Contributor Author

emilio commented Jun 22, 2022

Rebased on top of current trunk.

@hsivonen
Copy link
Member

Oops. This needs hash regeneration still.

@hsivonen hsivonen self-requested a review June 22, 2022 14:02
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ for real this time. Thanks.

emilio added a commit to emilio/htmlparser that referenced this pull request Jun 22, 2022
This basically undoes the manual change from validator#70.
emilio added a commit to emilio/htmlparser that referenced this pull request Jun 22, 2022
@sideshowbarker sideshowbarker merged commit 18ccfd1 into validator:master Jun 23, 2022
@emilio emilio deleted the rm-menuitem branch June 23, 2022 10:26
emilio added a commit to emilio/htmlparser that referenced this pull request Jun 23, 2022
sideshowbarker pushed a commit that referenced this pull request Jun 23, 2022
sideshowbarker pushed a commit that referenced this pull request Jun 30, 2023
See Mozilla bug 1775477.

Co-authored-by: Henri Sivonen <[email protected]>
sideshowbarker pushed a commit that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants