-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mozilla bug 1372276 - Remove menuitem. #70
Conversation
r? @hsivonen I don't think the build failure is related to my patch, but let me know if that's wrong. |
The failure relates to a mismatch of the JSON library version. It seems that it's my fault. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ for landing once the Gecko changeset lands.
I reverted the change from my previous changeset that shouldn't have been there in the first place. It seems, though, that restarting the tests use the base revision that the PR was made from and not the new trunk. |
Rebased on top of current trunk. |
Oops. This needs hash regeneration still. |
See Mozilla bug 1775477.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ for real this time. Thanks.
This basically undoes the manual change from validator#70.
This basically undoes the manual change from validator#70.
This basically undoes the manual change from validator#70.
This basically undoes the manual change from #70.
See Mozilla bug 1775477. Co-authored-by: Henri Sivonen <[email protected]>
This basically undoes the manual change from #70.
No description provided.