VLS's suggestion for internal dependency break with meson 0.55.0 #139
Labels
Comments
|
Interesting. I haven't taken a look at this at all yet, but just from looking at your diff'ed output it looks like Meson 0.55.0 possibly changed the IDs used for build targets. |
Prince781
added a commit
that referenced
this issue
Sep 17, 2020
Meson 0.55 changed the way build dirs are named, which broke our hack to find extra target compiler flags in compile_commands.json Fixes #139
Prince781
added a commit
that referenced
this issue
Sep 17, 2020
Meson 0.55 changed the way build dirs are named, which broke our hack to find extra target compiler flags in compile_commands.json Fixes #139
|
@Cogitri please try out the fix and verify things work on your end. |
Prince781
added a commit
that referenced
this issue
Sep 18, 2020
Meson 0.55 changed the way build dirs are named, which broke our hack to find extra target compiler flags in compile_commands.json Fixes #139
Prince781
added a commit
that referenced
this issue
Sep 18, 2020
Meson 0.55 changed the way build dirs are named, which broke our hack to find extra target compiler flags in compile_commands.json Fixes #139
|
Hm, unfortunately it seems like it's not fixed with the latest commit from the
The project itself compiles fine though. Tested with meson 0.55.3 Here's the log if that helps: Thanks for looking into this! |
|
Strange. I managed to get it working on my end (with meson 0.55.3). @Cogitri can you restart VLS with debug mode enabled (see below) and paste the output here? |
|
Ah whoops, seems like it does work, I forgot to rebuild vala-lint against the new Vala version (0.50), it still pulled in vala 0.48 for me and I couldn't upgrade to vls built against vala 0.50 locally :) Works after I actually upgraded to the new version, thanks for working on this! :) |
|
@Cogitri awesome. Good to hear. |
Prince781
added a commit
that referenced
this issue
Sep 18, 2020
Meson 0.55 changed the way build dirs are named, which broke our hack to find extra target compiler flags in compile_commands.json Fixes #139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
After upgrading from meson 0.54.3 to meson 0.55.0, VLS stopped showing suggestions & finding symbols from an internal dependency of mine. My setup looks like this:
-> final executable (with main)
static library (contains everything but main()) |
-> various test executables
I defined the static lib like this in my meson.build:
And depend on it via
dependencies: static_lib_depin the executables which link against it. This works fine with meson 0.55.0 too (as in it builds and passes tests, etc.), but breaks VLS.I've diffed the output of VLS with meson 0.54.3 vs 0.55.0, in case that helps:
The text was updated successfully, but these errors were encountered: