Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift PM support updated. #41

Merged
merged 12 commits into from
Jan 23, 2020
Merged

Swift PM support updated. #41

merged 12 commits into from
Jan 23, 2020

Conversation

yuryks
Copy link
Contributor

@yuryks yuryks commented Jan 20, 2020

Updated to Swift 5.

@yuryks
Copy link
Contributor Author

yuryks commented Jan 20, 2020

Maybe tag should be updated to 4.0.1

@vadymmarkov
Copy link
Owner

Thanks! Any idea why travis is failing?

@yuryks
Copy link
Contributor Author

yuryks commented Jan 22, 2020 •
edited
Loading

I guess because of Swift 5. Xcode 10 is a minimum version for it.
Possible solution: set "osx_image": "xcode10.2" on CI or configure Swift PM to use toolchain version 4.2.

@yuryks
Copy link
Contributor Author

yuryks commented Jan 22, 2020

Are you going to update project to Swift 5 ?
You may create brach when5 where for MR with Swift PM manifest which uses toolchain of version 5. And master will be on Swift 4.2.

vadymmarkov
vadymmarkov approved these changes Jan 23, 2020
View reviewed changes
Copy link
Owner

@vadymmarkov vadymmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@vadymmarkov
Copy link
Owner

I think it's about time to update the project to Swift 5 😉

@vadymmarkov vadymmarkov merged commit 588c05b into vadymmarkov:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadymmarkov vadymmarkov vadymmarkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuryks @vadymmarkov