Sync frame 0.5 #44
Merged
Sync frame 0.5 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malleoz
force-pushed
the
frame_0_point_5
branch
2 times, most recently
from
57e6c33 to
c355d89
Compare
malleoz
commented
Feb 3, 2024
malleoz
commented
Feb 3, 2024
vabold
requested changes
Feb 3, 2024
vabold
reviewed
Feb 3, 2024
Comment on lines
+47
to
+66
| f32 dot_ = std::max(-1.0f, std::min(1.0f, dot(q1))); | ||
| bool bDot = dot_ < 0.0f; | ||
| dot_ = std::abs(dot_); | ||
|
|
||
| f32 acos = Mathf::acos(dot_); | ||
| f32 sin = Mathf::sin(acos); | ||
|
|
||
| f32 s; | ||
| if (std::abs(sin) < 0.00001f) { | ||
| s = 1.0f - t; | ||
| } else { | ||
| f32 invSin = 1.0f / sin; | ||
| f32 tmp0 = t * acos; | ||
| s = invSin * Mathf::sin(acos - tmp0); | ||
| t = invSin * Mathf::sin(tmp0); | ||
| } |
There was a problem hiding this comment.
I'm currently debating whether or not to standardize the Mathf namespace within EGG - I'm leaning towards standardizing it, as max, min, and abs are trivially easy to implement into Mathf, whereas sin and sqrt cannot be implemented into std. I'm interested in hearing more thoughts.
Comment on lines
+39
to
+42
| void KartMove::setKartSpeedLimit() { | ||
| constexpr f32 limit = 120.0f; | ||
| m_hardSpeedLimit = limit; | ||
| } |
There was a problem hiding this comment.
This function is so simple and easy to understand that it might not even be worth using constexpr.
There was a problem hiding this comment.
Up to you, given you work with constexpr more than I have.
malleoz
force-pushed
the
frame_0_point_5
branch
from
c355d89 to
f09cb29
Compare
malleoz
force-pushed
the
frame_0_point_5
branch
from
f09cb29 to
15080bb
Compare
vabold
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the expected values of
KartDynamics::m_posandKartDynamics::m_fullRotafter the call toKartObject::calcSub. Only variables which are dependent on the synchronization of these two variables have been implemented.Further additions in the functions added in this PR may be required in order to sync the second pass.