Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconditionally call calcRejection #272

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Unconditionally call calcRejection #272

merged 1 commit into from
Mar 4, 2025

Conversation

malleoz
Copy link
Contributor

@malleoz malleoz commented Mar 4, 2025

Independently ran into this issue separately from John's PR #264

Short-circuiting prevented some calls to calcRejection.

NOTE: This will affect STATUS.md for #271 as follows:

rr-rta-1-24-751         3194    ->      5491    [LABEL]
rr-ng-rta-2-24-281      1207    ->      2217    [LATER]

@vabold vabold merged commit 72715ff into vabold:main Mar 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malleoz @vabold