Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add form layout row spacing, deprecate form item row spacing #8624

Merged

Conversation

DiegoCardoso
Copy link
Contributor

Description

Add warning when the --vaadin-form-item-row-spacing is set in the FormItem mentioned that the CSS variable has been deprecated.

Part of #8583

@DiegoCardoso DiegoCardoso requested a review from vursen February 3, 2025 14:15
packages/form-layout/test/form-layout.test.js Outdated Show resolved Hide resolved
packages/form-layout/test/form-layout.test.js Outdated Show resolved Hide resolved
packages/form-layout/src/vaadin-form-item-mixin.js Outdated Show resolved Hide resolved
@vursen
Copy link
Contributor

vursen commented Feb 4, 2025

#8635 should fix the failure of form layout > hidden > should update steps on show after hidden.

@vursen vursen changed the title refactor: depecreate --vaadin-form-item-row-spacing CSS variable refactor: add form layout row spacing, deprecate form item row spacing Feb 4, 2025
@vursen vursen changed the title refactor: add form layout row spacing, deprecate form item row spacing feat: add form layout row spacing, deprecate form item row spacing Feb 4, 2025
Copy link

sonarqubecloud bot commented Feb 4, 2025

@DiegoCardoso DiegoCardoso merged commit 422ca61 into main Feb 4, 2025
9 checks passed
@DiegoCardoso DiegoCardoso deleted the docs/form-layout/depecreate-form-item-row-spacing branch February 4, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants