-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add form layout row spacing, deprecate form item row spacing #8624
Merged
DiegoCardoso
merged 8 commits into
main
from
docs/form-layout/depecreate-form-item-row-spacing
Feb 4, 2025
Merged
feat: add form layout row spacing, deprecate form item row spacing #8624
DiegoCardoso
merged 8 commits into
main
from
docs/form-layout/depecreate-form-item-row-spacing
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Feb 3, 2025
vursen
reviewed
Feb 4, 2025
vursen
reviewed
Feb 4, 2025
vursen
reviewed
Feb 4, 2025
#8635 should fix the failure of |
--vaadin-form-item-row-spacing
CSS variable
1 task
Co-authored-by: Sergey Vinogradov <[email protected]>
|
vursen
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add warning when the
--vaadin-form-item-row-spacing
is set in theFormItem
mentioned that the CSS variable has been deprecated.Part of #8583