Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade SauceLabs launcher to the version based on Webdriver 9 #8573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Jan 28, 2025

Description

My PR to @web/test-runner-saucelabs was merged and released: modernweb-dev/web#2852

  • Upgraded the dev dependency version in package.json, let's see if visual tests pass.
  • Updated filterBrowserLogs to filter out webdriver debug warnings from their customElements wrapper

Type of change

  • Internal change

Note

There are some webdriver errors when running tests for more than a single file.
Added a comment about that here webdriverio/webdriverio#13467 (comment)

UPD: reported a new issue for this error webdriverio/webdriverio#14129

@web-padawan web-padawan requested a review from vursen January 28, 2025 09:13
@web-padawan web-padawan force-pushed the chore/bump-sauce-launcher branch from 4d38c5f to 0df4863 Compare January 28, 2025 10:28
@web-padawan
Copy link
Member Author

There are some problems with custom "set-window-height" command, I'll look into switching to setViewport().

 ❌ Error: Error while executing command set-window-height with payload {"height":610}: WebDriverError: unknown error: failed to change window state to 'normal', current state is 'maximized'

@web-padawan
Copy link
Member Author

Created #8577 to fix the CSS override for vaadin-multi-select-combo-box to properly hide caret in focused chip test.

@web-padawan web-padawan force-pushed the chore/bump-sauce-launcher branch 2 times, most recently from 401ef7c to b860f87 Compare January 28, 2025 13:54
@web-padawan web-padawan force-pushed the chore/bump-sauce-launcher branch from b860f87 to e675786 Compare January 29, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant