fix: check for bad input when updating _hasInputValue

[vursen]

Description

Native [type=number] inputs don't update their value when you are entering input that the browser is unable to parse e.g. --5 which results in _hasInputValue not being updated either. To work this out, the PR modifies the computation of _hasInputValue for number-field so that it would additionally check for bad input based on the native validity.badInput property and then update _hasInputValue accordingly.

Related to vaadin/flow-components#4272

Part of vaadin/platform#3066.

Type of change

• Bugfix

Checklist

• I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
• I have added a description following the guideline.
• The issue is created in the corresponding repository and I have referenced it.
• I have added tests to ensure my change is effective and works as intended.
• New and existing tests are passing locally with my change.
• I have performed self-review and corrected misspellings.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[vaadin-bot]

Hi @vursen , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 799d3e5
error: could not apply 799d3e5... fix: check for bad input when updating _hasInputValue (#5092)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[web-padawan]

I'm not sure if we should cherry-pick this now, but it's probably worth doing. In the future we might want to backport the whole set of validation improvements to a future minor e.g. 23.4 (especially in case it would be sponsored).

[vursen]

I'm not sure if we should cherry-pick this now, but it's probably worth doing. In the future we might want to backport the whole set of validation improvements to a future minor e.g. 23.4 (especially in case it would be sponsored).

Sounds reasonable, let's cherry-pick it while it is fresh in our minds.

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.0.0.alpha6 and is also targeting the upcoming stable 24.0.0 version.