fix: sync the hasInputValue state on input

[vursen]

Description

It turns out that TimePicker prevents the change event on the input element until it loses focus, so it is possible to commit a non-empty value on Enter but have the hasInputValue state not updated.

This PR makes the hasInputValue state update on input rather than change which ensures hasInputValue is synced in the above case as well.

A follow-up to #4276

Related to vaadin/flow-components#3515

Type of change

• Bugfix

Checklist

• I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
• I have added a description following the guideline.
• The issue is created in the corresponding repository and I have referenced it.
• I have added tests to ensure my change is effective and works as intended.
• New and existing tests are passing locally with my change.
• I have performed self-review and corrected misspellings.

[vursen]

Although this PR fixes the claimed issue, I wonder if we should rather investigate why time-picker prevents the change event on Enter as it looks quite unexpected.

[vursen]

The change event gets prevented here:

web-components/packages/combo-box/src/vaadin-combo-box-mixin.js

Lines 775 to 782 in 71104da

	// Stop propagation of the enter event only if the dropdown is opened, this
	// "consumes" the enter event for the action of closing the dropdown
	if (this.opened) {
	// Do not submit the surrounding form.
	e.preventDefault();
	// Do not trigger global listeners
	e.stopPropagation();
	}

As follows from the comment, the logic is intended to prevent the form submission but in fact, preventDefault also prevents the change event.

[vursen]

Anyway, the current fix is still good enough to solve the original problem on the Flow side.

As for the change event not firing on Enter, I think it is not a big issue at the moment as I can't think of a use case where the user would need to listen for change directly on the slotted input element. At least, I don't think we encourage that, but tell me if I'm wrong.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[vaadin-bot]

This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version.