Set radio button checked on host click

[samiheikki]

Fixes #84

---

This change is 

[platosha]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @samiheikki)

---

src/vaadin-radio-button.html, line 211 at r1 (raw file):

            e.preventDefault();
            this.checked = true;
            this.setAttribute('active', '');

Setting the active state on click is not appropriate.

The active state should only be set during the click (set on mousedown, removed on mouseup), not after.

[samiheikki]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @platosha and @samiheikki)

---

src/vaadin-radio-button.html, line 211 at r1 (raw file):

Previously, platosha (Anton Platonov) wrote…

Setting the active state on click is not appropriate.

The active state should only be set during the click (set on mousedown, removed on mouseup), not after.

Good point. Removed it.

[tomivirkki]

---

src/vaadin-radio-button.html, line 208 at r2 (raw file):

        _handleClick(e) {
          if (!this.disabled) {

Can you add a test for this condition also? (Shouldn't set a disabled host checked on click)

[platosha]

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @samiheikki)

[samiheikki]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @platosha and @tomivirkki)

---

src/vaadin-radio-button.html, line 208 at r2 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

Can you add a test for this condition also? (Shouldn't set a disabled host checked on click)

Done.

[tomivirkki]

Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved