Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calcs for line breaks #114

Merged
merged 5 commits into from
Jun 10, 2019
Merged

Update calcs for line breaks #114

merged 5 commits into from
Jun 10, 2019

Conversation

yuriy-fix
Copy link
Contributor

@yuriy-fix yuriy-fix commented Jun 5, 2019

Edge 18 does not apply any styles to line break elements.
The logic is now changed to check if the next visible item is <br> and apply appropriate padding.


This change is Reviewable

@yuriy-fix yuriy-fix requested a review from web-padawan June 5, 2019 13:39
@web-padawan web-padawan requested a review from platosha June 6, 2019 12:16
@Haprog Haprog self-requested a review June 7, 2019 07:19
@Haprog
Copy link
Contributor

Haprog commented Jun 7, 2019

Not sure why one of the Travis jobs shows as "Pending" here but it has actually finished successfully. Should be good to merge.

src/vaadin-form-layout.html Outdated Show resolved Hide resolved
src/vaadin-form-layout.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants