Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit height for the content part in order to allow user content to use relative height as well #56

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Use explicit height for the content part in order to allow user content to use relative height as well #56

merged 1 commit into from
Nov 15, 2018

Conversation

jouni
Copy link
Member

@jouni jouni commented Nov 15, 2018 •
edited by alexberazouski
Loading

Fixes #51

This change is Reviewable

alexberazouski
alexberazouski approved these changes Nov 15, 2018
View reviewed changes
Copy link

@alexberazouski alexberazouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@alexberazouski alexberazouski merged commit 025fc18 into master Nov 15, 2018
@alexberazouski alexberazouski deleted the fix/content-part-height branch November 15, 2018 15:57
@alvarezguille alvarezguille mentioned this pull request Nov 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexberazouski alexberazouski alexberazouski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jouni @alexberazouski