Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LitElement conversion part 2: src and unit tests #134

Merged
merged 11 commits into from
Feb 7, 2020
Merged

LitElement conversion part 2: src and unit tests #134

merged 11 commits into from
Feb 7, 2020

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Feb 3, 2020 •
edited
Loading

Connected to #128

Needs vaadin/component-mixins#42

@web-padawan web-padawan requested a review from yuriy-fix February 3, 2020 09:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 528

  • 101 of 101 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.3%) to 100.0%
Totals Coverage Status
Change from base Build 492: 8.3%
Covered Lines: 101
Relevant Lines: 101
💛 - Coveralls

@web-padawan web-padawan changed the base branch from master to next February 3, 2020 10:45
@web-padawan web-padawan mentioned this pull request Feb 3, 2020
Merged
@web-padawan web-padawan mentioned this pull request Feb 4, 2020
Merged
@web-padawan web-padawan changed the base branch from next to next-prepare February 5, 2020 09:19
@web-padawan web-padawan mentioned this pull request Feb 5, 2020
Merged
DiegoCardoso
DiegoCardoso approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@web-padawan web-padawan merged commit 413bbff into next-prepare Feb 7, 2020
@web-padawan web-padawan deleted the next-src branch February 7, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moderndeveloperllc moderndeveloperllc moderndeveloperllc left review comments

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

@yuriy-fix yuriy-fix Awaiting requested review from yuriy-fix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@web-padawan @coveralls @DiegoCardoso @moderndeveloperllc