fix: Do not allow border to grow row height #12254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If css grows row height the VSrollTable rowHeight logic does not work allways Fixes: #12251
edler-san
reviewed
Mar 25, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TatuLund)
OlliTietavainenVaadin
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Reviewable status:
dyorgio
reviewed
Nov 28, 2021
| } | ||
|
|
||
| .#{$primary-stylename}-table tr:first-child > td { | ||
| height: $v-table-row-height; |
There was a problem hiding this comment.
This broke all my custom tables (I need to specify a tr:first-child too).
But also broke valo compact style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If css grows row height the VSrollTable rowHeight logic does not work allways
Fixes: #12251
This change is