Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add method to write only the changed properties to the bean #18636

Merged
merged 7 commits into from
Feb 12, 2024
Merged

feat: Add method to write only the changed properties to the bean #18636

merged 7 commits into from
Feb 12, 2024

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Feb 7, 2024

fixes #18583

@mcollovati mcollovati added the Contribution PRs coming from the community or external to the team label Feb 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024 •
edited
Loading

Test Results

1 092 files  ±0  1 092 suites  ±0   1h 18m 16s ⏱️ - 1m 12s
6 858 tests +3  6 812 ✅ +3  46 💤 ±0  0 ❌ ±0 
7 208 runs  +6  7 150 ✅ +6  58 💤 ±0  0 ❌ ±0 

Results for commit 28a38b6. ± Comparison against base commit 39d0e9a.

♻️ This comment has been updated with latest results.

@TatuLund
Fixes according to review
2da92f0 
- Sanity check bindings to write in writeBean
- Return immutable Set in getBindings
@TatuLund
Update tests
ca87fc6
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Feb 10, 2024
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Feb 12, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mshabarov mshabarov merged commit f7e754a into main Feb 12, 2024
26 checks passed
@mshabarov mshabarov deleted the fix18583 branch February 12, 2024 11:40
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha4 and is also targeting the upcoming stable 24.4.0 version.

@mcollovati mcollovati mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov left review comments

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
Contribution PRs coming from the community or external to the team prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha4 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binder: Add method to write only the changed properties to the bean
5 participants
@TatuLund @vaadin-bot @mcollovati @mshabarov @tepi