Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GridPro editing in Dialog fails after first time #2319

Closed
kklein-celera opened this issue Nov 3, 2021 · 3 comments · Fixed by #2409
Closed

GridPro editing in Dialog fails after first time #2319

kklein-celera opened this issue Nov 3, 2021 · 3 comments · Fixed by #2409
Labels
bug Something isn't working Impact: High Released with Platform 14.8.1 Severity: Major vaadin-grid-pro

Comments

@kklein-celera
Copy link

Scenario:
A Dialog class contains a GridPro component. The GridPro has editable columns, one of which is custom. The Dialog instance is re-used across multiple invocations of open().

Issue:
The first time the Dialog is displayed, everything works as expected. If you close the Dialog, then open it again on different data, the editing for the custom columns is broken. You get a client-side error and the cell gets blanked out.

The client-side error message is: TypeError: Cannot read properties of null (reading 'localName')

Environment
Vaadin 14.7.2
Java 11
Windows 10
Chrome 95
IntelliJ IDEA 2021.2.2

See the attachments for a reproducible test case
test.zip
.
@TatuLund TatuLund transferred this issue from vaadin/flow Nov 5, 2021
@kklein-celera
Copy link
Author

kklein-celera commented Dec 8, 2021 •
edited
Loading

Could this be a duplicate of web-components issue 2466?
vaadin/web-components#2466

@TatuLund TatuLund mentioned this issue Dec 9, 2021
Merged
@TatuLund
Copy link
Contributor

TatuLund commented Dec 9, 2021

Could this be a duplicate of web-components issue 2466?

Yes it kind of is ... Or the root cause is the same. When Dialog is closed GridPro will be detached and when opened it will be attached again, so the cycle is there.

This was referenced Dec 15, 2021
Merged
Merged
sissbruecker pushed a commit that referenced this issue Dec 15, 2021
@TatuLund @sissbruecker
fix: register custom editor onAttach (#2409)
eb31f1a 
Cherry-pick of: #2409
Fixes #2466
Fixes #2319

Co-authored-by: Sascha Ißbrücker <[email protected]>
Co-authored-by: Sascha Ißbrücker <[email protected]>

(cherry picked from commit 56c878a)
@sissbruecker sissbruecker mentioned this issue Dec 15, 2021
Merged
ZheSun88 pushed a commit that referenced this issue Dec 20, 2021
@sissbruecker @TatuLund
fix: register custom editor onAttach (#2409) (#2432)
f0d0a9c 
Cherry-pick of: #2409
Fixes #2466
Fixes #2319

Co-authored-by: Sascha Ißbrücker <[email protected]>
Co-authored-by: Sascha Ißbrücker <[email protected]>

(cherry picked from commit 56c878a)

Co-authored-by: Tatu Lund <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Impact: High Released with Platform 14.8.1 Severity: Major vaadin-grid-pro
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: register custom editor onAttach vaadin/flow-components
4 participants
@alvarezguille @TatuLund @vaadin-bot @kklein-celera