Merge pull request #93 from uzairfarooq/dev

Prepare release 2.5.1
uzairfarooq · Nov 27, 2024 · 2ac2c6b · 2ac2c6b
2 parents ab1b8eb + 28c55a5
commit 2ac2c6b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "arrive",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "Watch for DOM elements creation and removal.",
   "main": "src/arrive.js",
   "keywords": [

diff --git a/minified/arrive.min.js b/minified/arrive.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "arrive",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "arrive.js provides events to watch for DOM elements creation and removal. It makes use of Mutation Observers internally.",
   "main": "src/arrive.js",
   "directories": {

diff --git a/src/arrive.js b/src/arrive.js
@@ -4,7 +4,7 @@
 
 /*
  * arrive.js
- * v2.5.0
+ * v2.5.1
  * https://github.com/uzairfarooq/arrive
  * MIT licensed
  *
@@ -363,7 +363,7 @@ var Arrive = (function(window, $, undefined) {
     // override bindEvent function
     arriveEvents.bindEvent = function(selector, arg2, arg3) {
 
-      var options = (typeof arg2 === 'object') ? utils.mergeArrays(arriveDefaultOptions, arg2) : arriveDefaultOptions;
+      var options = (typeof arg2 === 'object') ? utils.mergeArrays(arriveDefaultOptions, arg2) : { ...arriveDefaultOptions };
       var callback = (typeof arg3 === 'function') ? arg3 : (typeof arg2 === 'function') ? arg2 : undefined;
       var elements = utils.toElementsArray(this);
 
@@ -449,12 +449,15 @@ var Arrive = (function(window, $, undefined) {
     // override bindEvent function
     leaveEvents.bindEvent = function(selector, arg2, arg3) {
 
-      var options = (typeof arg2 === 'object') ? utils.mergeArrays(leaveDefaultOptions, arg2) : leaveDefaultOptions;
+      var options = (typeof arg2 === 'object') ? utils.mergeArrays(leaveDefaultOptions, arg2) : { ...leaveDefaultOptions };
       var callback = (typeof arg3 === 'function') ? arg3 : (typeof arg2 === 'function') ? arg2 : undefined;
 
       if (callback) {
         mutationBindEvent.call(this, selector, options, callback);
       } else {
+        // For promise and async support, we can only do onceOnly=true
+        options.onceOnly = true;
+
         var a = this;
         return new Promise(resolve => mutationBindEvent.call(a, selector, options, resolve));
       }