-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSv3 - UI skeleton and Hub details page #9830
base: issv3
Are you sure you want to change the base?
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9830/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
391c577
to
a609fcf
Compare
a609fcf
to
1ce0108
Compare
1ce0108
to
2cf88c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot say much about typescript, but the java code is ok - just one note.
But you should check SonarCloud findings
@@ -93,7 +108,7 @@ public static void initRoutes(JadeTemplateEngine jade) { | |||
public static ModelAndView showMonitoring(Request request, Response response, User user) { | |||
Map<String, Object> data = new HashMap<>(); | |||
data.put("isUyuni", ConfigDefaults.get().isUyuni()); | |||
return new ModelAndView(data, "controllers/admin/templates/monitoring.jade"); | |||
return new ModelAndView(data, "controllers/admin/templates/issv3/monitoring.jade"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better use "hub" instead of "issv3" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm, let me double check this I don't think we should have changed it.
Those are all related to the "fake" peripheral part. I think I'll probably just remove it, so sonarcloud won't complain. |
What does this PR change?
This PR adds the menu and the navigation to make the previously made pages accessible and adds the hub details page
NOTE: all the pages and the features around peripherals are included only as mock, they will be part of an additional PR.
GUI diff
After:





Documentation
Documentation WIP
DONE
Test coverage
Unit tests were added
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/25355
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!