Correctly switch to Salt Bundle on transactional systems (bsc#1232562)

[joyetamdk]

What does this PR change?

Enables venv-salt-minion.service after salt-bundle conversion and disables salt-minion.service depending on the system, if its transactional or non-transactional

GUI diff

No difference.

• DONE

Documentation

• No documentation needed

• DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

• No tests

• DONE

Links

Issue(s): # https://github.com/SUSE/spacewalk/issues/25795
Port(s): # add downstream PR(s), if any

• DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

[agraul]

Thank you for the pull request! The approach looks good, with the current service state module needing dbus, this way is good workaround to only disable or enable services.

mgr_disable_salt_minion has the same problem as mgr_enable_venv_salt_minion, please add a similar workaround for that state.

[agraul]

This implementation (with additional arguments) is already defined in lines 59-64. I would drop this part and move the Jinja2 if/else control structure to the existing definition (together with the transactional-update branch.

[agraul]

This dependency is still required here.

[agraul]

The changelog needs to mention the bug id and is target at the end-user. I think the current wording is not very clear for end-users. How about the following?

Suggested change

	- Enable venv-salt-minion disable salt-minion service based on os
	- Correctly switch to Salt Bundle on transactional systems
	(bsc#1232562)

[agraul]

Thank you for the update, the code and changelog look good now 🚀

! It would be great if you could fill out the rest of the pull request description template and we're ready to merge this PR. For the "Links" section you can already create backports for 4.3 and 5.0 and add links to those pull requests.