SSM and systems groups

[Pablogoliva]

What does this PR change?

This PR adds some smoke test to SSM and systems groups test features and fixes:https://github.com/SUSE/spacewalk/issues/15437

GUI diff

No difference.

• DONE

Documentation

• No documentation needed

• DONE

Test coverage

• Cucumber tests were added

• DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/15437
Port(s):

• Manager 5.0:

• Manager 4.3:

• DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

[github-actions]

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9787/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9787/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

[Bischoff]

see comments

[NamelessOne91]

Thanks Pablo

I left some nitpicks/suggestion which are about naming scenarios and form.
The actual logic and steps LGTM

PS: add an empty new line at the end of the file ;)

[ktsamis]

Small question about removing RHlike minion from the group, why do we do that? Otherwise seems good

[Bischoff]

LGTM

[NamelessOne91]

Thanks for the changes, LGTM

[srbarrios]

What about include the tag @sle_minion ?
This feature depends on having a SLE minion deployed, so it make sense to skip it if the minion is not present.

[srbarrios]

Also, as we are enhancing this feature, maybe we can also consider to create a new Cucumber profile.
If you go to testsuite/config/cucumber.yml you will see that we have a list of Cucumber profiles, that runs when the Cucumber feature have some specified tags.

What about creating a new one for the SSM feature?

ssm: --tags @scope_ssm

And then we add the new tag on top of this feature like:

@scope_visualization
@scope_ssm
@sle_minion
Feature: Manage a group of systems
...

Some info about Cucumber profiles integration explained on these slides: https://oubiti.com/smart-integration-tests/

[srbarrios]

Just some suggestions, but LGTM

[Pablogoliva]

Small question about removing RHlike minion from the group, why do we do that? Otherwise seems good

Because this test was worng were missing sle_mions with rhlike minions