Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLAS, hipSYCL] Add CUDA_CUDA_LIBRARY to also link against libcuda.so #249

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

nilsfriess
Copy link
Contributor

@nilsfriess nilsfriess commented Nov 9, 2022

Description

PR #228 added calls to cuStreamSynchronize in the cuBLAS backend. This function is located in libcuda.so but this library is not linked against when using hipSYCL to compile oneMKL. This PR adds CUDA_CUDA_LIBRARY in FindcuBLAS.cmake to fix this.

Checklist

Copy link
Contributor

@mkrainiuk mkrainiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! The changes look good to me.

@andrewtbarker andrewtbarker self-requested a review November 11, 2022 00:39
Copy link
Contributor

@andrewtbarker andrewtbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@andrewtbarker andrewtbarker merged commit 15946f8 into uxlfoundation:develop Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants