Introduction of release notes and applied resolved comments in #2052 #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmiesmith
requested review from
dcbenito,
akukanov,
MikeDvorskiy,
dmitriy-sobolev,
egfefey,
mmichel11,
danhoeflinger,
adamfidel and
SergeyKopienko
timmiesmith
commented
Feb 14, 2025
mmichel11
reviewed
Feb 14, 2025
Co-authored-by: Matthew Michel <[email protected]>
Co-authored-by: Dmitriy Sobolev <[email protected]>
Co-authored-by: Dmitriy Sobolev <[email protected]>
Co-authored-by: Dmitriy Sobolev <[email protected]>
dcbenito
previously requested changes
Feb 19, 2025
timmiesmith
commented
Feb 19, 2025
Co-authored-by: Dmitriy Sobolev <[email protected]>
akukanov
reviewed
Feb 19, 2025
timmiesmith
requested review from
mmichel11,
dmitriy-sobolev,
dcbenito and
danhoeflinger
akukanov
reviewed
Feb 20, 2025
akukanov
reviewed
Feb 20, 2025
akukanov
reviewed
Feb 20, 2025
|
Looks good to me overall. |
timmiesmith
dismissed
dcbenito’s stale review
All changes requested in the review have been made.
akukanov
reviewed
Feb 20, 2025
akukanov
previously approved these changes
Feb 20, 2025
Signed-off-by: Matthew Michel <[email protected]>
Signed-off-by: Matthew Michel <[email protected]>
timmiesmith
commented
Feb 20, 2025
Signed-off-by: Matthew Michel <[email protected]>
timmiesmith
commented
Feb 20, 2025
timmiesmith
added a commit
that referenced
this pull request
Feb 20, 2025
--------- Co-authored-by: Matthew Michel <[email protected]> Co-authored-by: Dmitriy Sobolev <[email protected]> Co-authored-by: Alexey Kukanov <[email protected]> Co-authored-by: Matthew Michel <[email protected]>
dcbenito
reviewed
Feb 20, 2025
| with device policies for large data sizes. | ||
| - Improved performance of ``copy``, ``fill``, ``for_each``, ``replace``, ``reverse``, ``rotate``, ``transform`` and 30+ | ||
| other algorithms with device policies on GPUs. | ||
| - Improved oneDPL use with SYCL implementations other than Intel oneDPI DPC++/C++ compiler. |
There was a problem hiding this comment.
Please update the compiler name: Intel® oneAPI DPC++/C++ Compiler
| - Fixed several issues in the ``sort``, ``stable_sort``, ``sort_by_key`` and ``stable_sort_by_key`` algorithms that: | ||
|
|
||
| * Allows the use of non-trivially-copyable comparators. | ||
| * Eliminates duplicate kernel names |
There was a problem hiding this comment.
Please add a period at the end of this bullet.
| ---------------------------- | ||
| New in This Release | ||
| ^^^^^^^^^^^^^^^^^^^ | ||
| - Incorrect results may be observed when calling ``sort`` with a device policy on Intel® Arc™ Graphics 140V with data |
There was a problem hiding this comment.
This instance of the name calls for a lowercase "g" in "graphics". Please update the name to Intel® Arc™ graphics.
| sizes of 4-8 million elements. | ||
| - ``sort``, ``stable_sort``, ``sort_by_key`` and ``stable_sort_by_key`` algorithms fail to compile | ||
| when using Clang 17 and earlier versions, as well as compilers based on these versions, | ||
| such as Intel(R) oneAPI DPC++/C++ Compiler 2023.2.0. |
There was a problem hiding this comment.
Please change the (R) to ® for consistency.
| such as Intel(R) oneAPI DPC++/C++ Compiler 2023.2.0. | ||
| - When compiling code that uses device policies with the open source oneAPI DPC++ Compiler (clang++ driver), | ||
| synchronous SYCL runtime exceptions regarding unfound kernels may be encountered unless an optimization flag is | ||
| specified (e.g. ``-O1``) as opposed to relying on the compiler's default optimization level. |
There was a problem hiding this comment.
Please change "e.g." to "for example".
timmiesmith
added a commit
that referenced
this pull request
Feb 20, 2025
#2074) --------- Co-authored-by: Matthew Michel <[email protected]> Co-authored-by: Dmitriy Sobolev <[email protected]> Co-authored-by: Alexey Kukanov <[email protected]> Co-authored-by: Matthew Michel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening PR for 2022.8 release notes.